potiuk commented on code in PR #57899: URL: https://github.com/apache/airflow/pull/57899#discussion_r2496464897
########## dev/breeze/src/airflow_breeze/global_constants.py: ########## @@ -204,7 +204,6 @@ ] USE_AIRFLOW_MOUNT_SOURCES = [MOUNT_REMOVE, MOUNT_TESTS, MOUNT_PROVIDERS_AND_TESTS] -ALLOWED_POSTGRES_VERSIONS = ["13", "14", "15", "16", "17"] Review Comment: Allowed postgres versions were specifically used to handle "dropping" old versions and adding new versions - so that change should add newer version to "allowed" and "current" and remove old version from "current". This is to make it easier to test supported versions on breeze with `--use-airflow-versions` Until we go to 3.2., Airflow 3.1 still support Postgres 13 and we need to be able to test it with Postgres 13 until we stop releasing 3.1.* Having "allowed" versions with 13 allows to do this: * `breeze start-airflow --use-airflow-version 3.1.2 --backend postgres --postgres-version 13` * Allowed means "you can use it as parameter value" * Current means "those we currently test in CI" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
