guan404ming commented on code in PR #57547:
URL: https://github.com/apache/airflow/pull/57547#discussion_r2500126726
##########
airflow-core/src/airflow/ui/src/utils/hitl.ts:
##########
@@ -125,10 +125,10 @@ export const getHITLParamsDict = (
minLength: undefined,
section: undefined,
title: key,
- type: valueType,
+ type: typeof value === "number" ? "number" : "string",
values_display: undefined,
},
- value: preloadedHITLParams[key] ?? value,
+ value: paramData?.value ?? paramData ?? value,
Review Comment:
```suggestion
value: paramData?.value ?? value,
```
I think we could remove the paramData here
##########
airflow-core/src/airflow/ui/src/utils/hitl.ts:
##########
@@ -108,11 +108,11 @@ export const getHITLParamsDict = (
const sourceParams = hitlDetail.response_received ?
hitlDetail.params_input : hitlDetail.params;
Review Comment:
Maybe we could split `received` and `not recieved` into two parts and
handle them separately, since their types are different now, which makes it
painful to code them together.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
