Lee-W commented on code in PR #57547:
URL: https://github.com/apache/airflow/pull/57547#discussion_r2501416702
##########
airflow-core/src/airflow/ui/src/utils/hitl.ts:
##########
@@ -108,11 +108,11 @@ export const getHITLParamsDict = (
const sourceParams = hitlDetail.response_received ?
hitlDetail.params_input : hitlDetail.params;
Object.entries(sourceParams ?? {}).forEach(([key, value]) => {
- const valueType = typeof value === "number" ? "number" : "string";
+ const paramData = hitlDetail.params?.[key] ?? {};
paramsDict[key] = {
- description: "",
- schema: {
+ description: paramData?.description ?? "",
+ schema: paramData?.schema ?? {
Review Comment:
For backward compatibility, we might not be able to do that. Not sure
whether there's smart way to do it in the frontend 🤔
For older provider, we still want to make `{"key": "value"}` work fine
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
