jscheffl commented on code in PR #57700:
URL: https://github.com/apache/airflow/pull/57700#discussion_r2506845464
##########
airflow-core/src/airflow/executors/executor_loader.py:
##########
@@ -74,11 +74,11 @@ def _get_executor_names(cls) -> list[ExecutorName]:
all_executor_names: list[tuple[str | None, list[str]]] =
cls._get_team_executor_configs()
- executor_names = []
+ executor_names: list[ExecutorName] = []
for team_name, executor_names_config in all_executor_names:
executor_names_per_team = []
- for name in executor_names_config:
- if len(split_name := name.split(":")) == 1:
+ for executor_name_str in executor_names_config:
Review Comment:
Attempted this before but then `executor_name` is re-used in line 129ff in
the loop and generated a clash there. First I renamed below but then realized
that the name below is a very good fit - so decided rather finding an
alternative here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
