jscheffl commented on code in PR #57700:
URL: https://github.com/apache/airflow/pull/57700#discussion_r2506865508
##########
airflow-core/src/airflow/serialization/serde.py:
##########
@@ -365,30 +365,29 @@ def _register():
_stringifiers.clear()
with Stats.timer("serde.load_serializers") as timer:
- for _, name, _ in iter_namespace(airflow.serialization.serializers):
- name = import_module(name)
- for s in getattr(name, "serializers", ()):
- if not isinstance(s, str):
- s = qualname(s)
- if s in _serializers and _serializers[s] != name:
- raise AttributeError(f"duplicate {s} for serialization in
{name} and {_serializers[s]}")
+ for _, module_name, _ in
iter_namespace(airflow.serialization.serializers):
+ module = import_module(module_name)
+ for serializers in getattr(module, "serializers", ()):
+ s = serializers if isinstance(serializers, str) else
qualname(serializers)
Review Comment:
Good point, applied!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
