amoghrajesh commented on code in PR #58223:
URL: https://github.com/apache/airflow/pull/58223#discussion_r2517332106
##########
task-sdk/src/airflow/sdk/definitions/decorators/__init__.pyi:
##########
@@ -29,10 +29,10 @@ from kubernetes.client import models as k8s
from airflow.providers.cncf.kubernetes.secret import Secret
from airflow.sdk.bases.decorator import FParams, FReturn, Task, TaskDecorator,
_TaskDecorator
+from airflow.sdk.definitions._internal.typing_compat import Literal
Review Comment:
That makes sense thanks.
##########
task-sdk/src/airflow/sdk/definitions/dag.py:
##########
@@ -67,12 +67,12 @@
from pendulum.tz.timezone import FixedTimezone, Timezone
from airflow.models.taskinstance import TaskInstance as
SchedulerTaskInstance
+ from airflow.sdk.definitions._internal.typing_compat import Self
Review Comment:
That makes sense, thanks
##########
task-sdk/src/airflow/sdk/definitions/_internal/typing_compat.py:
##########
@@ -0,0 +1,32 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+"""This module provides helper code to make type annotation within Airflow SDK
easier."""
+
+from __future__ import annotations
+
+__all__ = [
+ "Literal",
+ "Self",
+]
+
+import sys
+from typing import Literal
Review Comment:
Yeah, if its only used for typing I can just get rid of this then
##########
task-sdk/src/airflow/sdk/definitions/dag.py:
##########
@@ -67,12 +67,12 @@
from pendulum.tz.timezone import FixedTimezone, Timezone
from airflow.models.taskinstance import TaskInstance as
SchedulerTaskInstance
+ from airflow.sdk.definitions._internal.typing_compat import Self
Review Comment:
Handled in [remove typing
module](https://github.com/apache/airflow/pull/58223/commits/c7733ebe962b20fc435f842311c3e77ac671356d)
##########
task-sdk/src/airflow/sdk/definitions/_internal/typing_compat.py:
##########
@@ -0,0 +1,32 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+"""This module provides helper code to make type annotation within Airflow SDK
easier."""
+
+from __future__ import annotations
+
+__all__ = [
+ "Literal",
+ "Self",
+]
+
+import sys
+from typing import Literal
Review Comment:
Handled in [remove typing
module](https://github.com/apache/airflow/pull/58223/commits/c7733ebe962b20fc435f842311c3e77ac671356d)
##########
task-sdk/src/airflow/sdk/definitions/decorators/__init__.pyi:
##########
@@ -29,10 +29,10 @@ from kubernetes.client import models as k8s
from airflow.providers.cncf.kubernetes.secret import Secret
from airflow.sdk.bases.decorator import FParams, FReturn, Task, TaskDecorator,
_TaskDecorator
+from airflow.sdk.definitions._internal.typing_compat import Literal
Review Comment:
Handled in [remove typing
module](https://github.com/apache/airflow/pull/58223/commits/c7733ebe962b20fc435f842311c3e77ac671356d)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
