uranusjr commented on code in PR #58223: URL: https://github.com/apache/airflow/pull/58223#discussion_r2517280218
########## task-sdk/src/airflow/sdk/definitions/_internal/typing_compat.py: ########## @@ -0,0 +1,32 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +"""This module provides helper code to make type annotation within Airflow SDK easier.""" + +from __future__ import annotations + +__all__ = [ + "Literal", + "Self", +] + +import sys +from typing import Literal Review Comment: We can just import from typing directly without going through this module. This was only re-exported in `airflow.typing_compat` for compatibility in providers. ########## task-sdk/src/airflow/sdk/definitions/dag.py: ########## @@ -67,12 +67,12 @@ from pendulum.tz.timezone import FixedTimezone, Timezone from airflow.models.taskinstance import TaskInstance as SchedulerTaskInstance + from airflow.sdk.definitions._internal.typing_compat import Self Review Comment: As @sunank200 mentioned, this doesn’t actually need a compat module. Mypy just parses the code without actually importing it, so simply `from typing import Self` would work if it’s inside the `TYPE_CHECKING` block, even on versions where `typing.Self` is not available. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
