potiuk commented on code in PR #58231: URL: https://github.com/apache/airflow/pull/58231#discussion_r2523385051
########## task-sdk-integration-tests/docker-compose-local.yaml: ########## @@ -0,0 +1,45 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# +--- +# If the image is locally built from the repo we can mount sources of Airflow so that +# We do not have to rebuild the image on every change +services: + airflow-init: + volumes: + - ../airflow-core/src:/opt/airflow/airflow-core/src + - ../task-sdk/src:/opt/airflow/task-sdk/src + environment: + - DEV_MODE=true + airflow-apiserver: + volumes: + - ../airflow-core/src:/opt/airflow/airflow-core/src + - ../task-sdk/src:/opt/airflow/task-sdk/src + environment: + - DEV_MODE=true + airflow-scheduler: + volumes: + - ../airflow-core/src:/opt/airflow/airflow-core/src + - ../task-sdk/src:/opt/airflow/task-sdk/src + environment: + - DEV_MODE=true + airflow-dag-processor: + volumes: + - ../airflow-core/src:/opt/airflow/airflow-core/src + - ../task-sdk/src:/opt/airflow/task-sdk/src + environment: + - DEV_MODE=true Review Comment: I did not consider it **necessarry** - in this case WET (Write Everyting Twice) is a bit more better than DRY - because it's more explicit. If we want to have a common part here we would have to use the not-so-funny syntax of inclusions in yaml, which is super non-intuitive and verbose. Also in the future we want to differentiate it. In Airflow 2 we will not mount task-sdk to scheduler or api-server, or airflow-init. and we can have more distributions in the future, so I figured explicit WET knowing that some coupling here is not really desired is a better approach. ########## task-sdk-integration-tests/docker-compose.yaml: ########## @@ -18,7 +18,7 @@ --- x-airflow-common: &airflow-common - image: ${AIRFLOW_IMAGE_NAME:-apache/airflow:3.0.3} Review Comment: Yeah. Was a abit like .... Why 3.0.3 ???? :D -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
