o-nikolas commented on PR #58231: URL: https://github.com/apache/airflow/pull/58231#issuecomment-3549876023
> It was not clear that when you build PROD images from sources, you should first compile ui assets, because otehrwise the assets are not added as part of the image. With this PR the breeze prod-image build command checks if the .vite manifest is present in the right dist folders and will error out, suggesting to run breeze compile-ui-assets before. @potiuk This change of this PR has broken our internal build infrastructure. We generate production images do run some tests with (the executor variants of our system tests). These tests are entirely headless and do not need UI assets (had been passing for years without them). I've played around with trying to compile the assets during our build, but not only does this add unnecessary build time, but because of an architectural constraint (long story short: we don't run with a direct git checkout, rather the files from an s3 zip that does not contain the `.git` file and this breaks the asset compilation) we cannot actually run the compilation. I'm thinking of adding an environment variable or flag to the build command to skip this new assertion. Thoughts? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
