potiuk commented on code in PR #58080:
URL: https://github.com/apache/airflow/pull/58080#discussion_r2524370164
##########
dev/breeze/src/airflow_breeze/commands/developer_commands.py:
##########
@@ -129,6 +130,18 @@
CELERY_INTEGRATION = "celery"
+def is_wsl() -> bool:
+ """Detect if we are running inside WSL."""
+ if platform.system() != "Linux":
Review Comment:
```suggestion
if platform.system().lower() not in ("linux", "darwin"):
```
##########
dev/breeze/src/airflow_breeze/commands/developer_commands.py:
##########
@@ -129,6 +130,18 @@
CELERY_INTEGRATION = "celery"
+def is_wsl() -> bool:
+ """Detect if we are running inside WSL."""
+ if platform.system() != "Linux":
Review Comment:
Ah noooo...
##########
dev/breeze/src/airflow_breeze/commands/developer_commands.py:
##########
@@ -129,6 +130,18 @@
CELERY_INTEGRATION = "celery"
+def is_wsl() -> bool:
+ """Detect if we are running inside WSL."""
+ if platform.system() != "Linux":
Review Comment:
```suggestion
if platform.system().lower() != "linux":
```
##########
dev/breeze/src/airflow_breeze/commands/developer_commands.py:
##########
@@ -129,6 +130,18 @@
CELERY_INTEGRATION = "celery"
+def is_wsl() -> bool:
+ """Detect if we are running inside WSL."""
+ if platform.system() != "Linux":
Review Comment:
Stupid me :) (hate negative checks)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
