potiuk commented on PR #56187: URL: https://github.com/apache/airflow/pull/56187#issuecomment-3529114632
> @potiuk Tests passed locally, let's see if the CI succeeds as well. > > I had to add a dependency to `airflow-core` like so > > ```diff > [dependency-groups] > dev = [ > "apache-airflow-devel-common", > + "apache-airflow-core", > "apache-airflow-shared-observability[all]", > ] > ``` > > to get it to work. I don't think it is a good idea. After doing it you have airflow-core -> observability -> airflow-core cycle ... That's not what it is supposed to be, it should be `airflow-core -> observability -> only extrernal dependencies. Generally the idea is that the `shared` project depends only on external things - and not on any of the other distributions. I think it should be easy to check by running `uv sync` in the corresponding directories (i.e. running uv-sync in the `observability` should install only things that `observability needs` + all dev dependencies needed to run tests - but those `dev` dependencies also should not need to include airflow-core. What was the problem when you removed sqlalchemy ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
