xBis7 commented on PR #56187: URL: https://github.com/apache/airflow/pull/56187#issuecomment-3538457624
> So ... Maybe we should wait for https://github.com/apache/airflow/pull/57744 to be completed then ? That's a good idea but that PR seems far from done. Another approach would be to merge this one with some TODO comments and afterwards change the imports and the dependency. > Also - this seems like a "dev" dependency only which suggests that what you need there, is really only in tests Good observation. But it's not just the tests that need the dependency, it's the main code too. This made me realize something that I have overlooked. Because the executable code is run from the tests, the context that sets them up has the dependency available but what will happen when the code will be run from another setup? The dependency will likely be missing. The packages that we need are 1. `airflow.configuration...` 2. `airflow.exceptions...` 3. `airflow.utils...` 4. `airflow.models...` And there is this import as well ```python if TYPE_CHECKING: from airflow.typing_compat import Self ``` Number 4 (models) is included in a file that's not needed anymore and I was planning to clean it up in the future. I can do it in this PR and get rid of the imports. Numbers 1 (config) and 2 (exceptions) are really needed and should be shared. For number 3, I can duplicate the code and get rid of the imports. > I think what you have problem with is not the actual uv test run etc but the fact is that you are running test from the IDE I'm not using the IDE. I try to reproduce CI errors the same way that the CI runs them. In this case, I do this ``` > cd shared/observability > uv run --group dev pytest --color=yes -n auto ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
