uranusjr commented on code in PR #58062:
URL: https://github.com/apache/airflow/pull/58062#discussion_r2532280340
##########
airflow-core/src/airflow/models/connection.py:
##########
@@ -372,12 +389,12 @@ def get_extra(self) -> str:
f"Can't decrypt `extra` params for login={self.login}, "
f"FERNET_KEY configuration is missing"
)
- extra_val = fernet.decrypt(bytes(self._extra, "utf-8")).decode()
+ extra_val: str | None = self._safe_decrypt(self._extra)
else:
extra_val = self._extra
if extra_val:
self._validate_extra(extra_val, self.conn_id)
- return extra_val
+ return extra_val or None
Review Comment:
I don’t this this function should return None. Probably better to just raise.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
