kacpermuda commented on PR #58393: URL: https://github.com/apache/airflow/pull/58393#issuecomment-3542040747
The more I think about it, the more questions/thoughts I have, but maybe they are all related to each other (I'll use common.compat as example): 1. When this `use next version` comment is encountered, we use the value from provider.yml of specific provider, make a replacement and we remove this comment. Is there any mechanism that forces the release manager to first bump the versions in provider.yml of all providers and then run this automation? Otherwise, we may end up silently removing this comment BEFORE versions are bumped, therefore not actually bumping the dependency - possibly releasing provider with broken features (it will try to use features from new version of some provider without requiring it in dependencies). 2. What is the incentive for contributors to use this method over explicitly bumping this version in the provider.yml of the dependent provider (e.g. common.compat)? I for sure would like to be certain, that this change is made and not merely left as a comment that may or may not be implemented to avoid potential problem with releasing provider with broken features (see above). 3. I guess it's related to the above, but does this mean that contributors have two ways of bumping this? One can bump the version of common.compat in its provider.yml and use new version in parent provider, or just leave the comment in parent provider and count that it will be seen? May be a bit confusing if there are two ways of achieving the same, and possibly, what if one contributor chooses first and the other chooses the second - we'll probably count on release manager to spot that it has already been bumped and he does not have to do it manually and then run the automation to update other provider.yml files. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
