potiuk commented on PR #58393: URL: https://github.com/apache/airflow/pull/58393#issuecomment-3543123861
> Selective checks is a good idea on PRs. Maybe we can think about a prek hook for it 🤔 Prek is not best - because it's best to see "what's coming in PR" - prek hook are not really good for it - we tried. Prek naturally works on all files by default or on currently staged changes - and it consider those files as "whole" - and you need to do some extra checks to compare current vs. previous version and it might be heavily skewed anyway - becuase you might not be rebased, and have multiple commits and such - so naturally the scope of `prek hook` is `current commit`. What we are looking for here is "change vs previous commit" - because we only want to flag situation when someone wants to change the dependent version in their PR (i.e. we have to compare vs. target branch - not what happened in a single commit).. Note that it should not flag if "other" parts of pyproject.toml changed -- we should only flag it if "version changed in the pr" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
