VladaZakharova commented on code in PR #56324:
URL: https://github.com/apache/airflow/pull/56324#discussion_r2536865424
##########
providers/google/docs/connections/gcp.rst:
##########
@@ -1,19 +1,19 @@
- .. Licensed to the Apache Software Foundation (ASF) under one
Review Comment:
I think we still need this indent, can you please return it back to how it
was?
##########
providers/google/src/airflow/providers/google/common/hooks/base_google.py:
##########
@@ -265,17 +266,34 @@ def get_ui_field_behaviour(cls) -> dict[str, Any]:
return {
"hidden_fields": ["host", "schema", "login", "password", "port",
"extra"],
"relabeling": {},
+ "placeholders": {
+ "quota_project_id": "Project ID to use for API quota and
billing (optional)",
Review Comment:
Is it really okay to have 2 fields with the same name inside "placeholders"
and "tooltips"?
##########
providers/google/tests/system/google/common/example_quota_project.py:
##########
@@ -0,0 +1,112 @@
+# Licensed to the Apache Software Foundation (ASF) under one
Review Comment:
Can you please share a screenshot of the green system test execution?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
