ashb commented on code in PR #57744:
URL: https://github.com/apache/airflow/pull/57744#discussion_r2537439828
##########
task-sdk/tests/task_sdk/execution_time/test_task_runner.py:
##########
@@ -3111,7 +3111,7 @@ def test_runtime_task_instance_log_url_property(self,
create_runtime_ti, base_ur
task = BaseOperator(task_id="test_task")
runtime_ti = create_runtime_ti(task=task, dag_id="test_dag",
run_id="test_run", try_number=0)
- with patch("airflow.configuration.conf.get", return_value=base_url):
+ with patch("airflow.sdk.configuration.conf.get",
return_value=base_url):
log_url = runtime_ti.log_url
assert log_url == expected_url
Review Comment:
Nit: why are we mocking this, rather than using conf_vars? Since we need to
change this line anyway, lets fix it to use that context manager instead of
patch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
