ashb commented on code in PR #57744:
URL: https://github.com/apache/airflow/pull/57744#discussion_r2537373435
##########
airflow-core/tests/unit/core/test_configuration.py:
##########
@@ -342,6 +336,8 @@ def test_config_from_secret_backend(self, mock_hvac):
"""
test_conf =
AirflowConfigParser(default_config=parameterized_config(test_config_default))
+ test_conf.set("secrets", "backend",
"airflow.providers.hashicorp.secrets.vault.VaultBackend")
+ test_conf.set("secrets", "backend_kwargs", '{"url":
"http://127.0.0.1:8200";, "token": "token"}')
Review Comment:
Why did we need to change this? I'd have expected the existing `@conf_vars`
fixture to still work?
If possible we shouldn't really change the tests with this kind of refactor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
