bugraoz93 commented on code in PR #58352:
URL: https://github.com/apache/airflow/pull/58352#discussion_r2542945459
##########
airflow-core/src/airflow/models/dagrun.py:
##########
@@ -435,6 +435,9 @@ def duration(cls, session: Session = NEW_SESSION) -> Case:
return case(when_condition, else_=None)
+ # Class-level expression for use in select statements
Review Comment:
Thanks for the change, this looks cleaner ! One smal nit is this is now
class level variable defined in the middle of the class. Maybe we can convert
this to a property since it is expression, it can be easily calculated under
property since it is not populating any data but generating sql expression
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
