pierrejeambrun commented on code in PR #58352:
URL: https://github.com/apache/airflow/pull/58352#discussion_r2556332469
##########
airflow-core/src/airflow/api_fastapi/core_api/routes/ui/dags.py:
##########
@@ -191,7 +191,7 @@ def get_dags(
DagRun.run_after,
DagRun.start_date,
DagRun.state,
- DagRun.duration,
+ DagRun.duration.expression, # type: ignore[attr-defined]
Review Comment:
Ideally we'd love to not have to type ignore this.
Sqlalchemy2 mypy errors fixing seems to not be straight forward, we end up
with a lot of hard casting, type ignore and stuff in the code when looking at
similars PR.
I didn't find enough time to dig deeper though, it can do for now I guess,
but its not super maintainable. (having to `type ignore` all hybrid property
queried is not super cool)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
