jayantsing-db commented on issue #58386: URL: https://github.com/apache/airflow/issues/58386#issuecomment-3554422267
>That's right and DatabricksHook should probably also overwrite set_autocommit method, as in base hook's [method](https://github.com/apache/airflow/blob/main/providers/common/sql/src/airflow/providers/common/sql/hooks/sql.py#L820) that is being called, the conn.autocommit = autocommit is executed regardless of self.supports_autocommit (it merely logs a warning on conflict). Agreed @kacpermuda, thanks @potiuk what are your thoughts on this? I am a maintainer of databricks sql connector and we have been discussing this internally. It's really not ideal for the driver to have a default OFF knob around major specs like transactions. Should we modify the default behaviour or documentation/communication of supports_autocommit flag in airflow and possibly override the set_autocommit method too. Additionally, @kacpermuda will you able to set supports_autocommit to false until your workspace is enrolled to the feature or the feature is generally available? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
