kacpermuda commented on code in PR #58497:
URL: https://github.com/apache/airflow/pull/58497#discussion_r2545046161
##########
providers/standard/src/airflow/providers/standard/triggers/external_task.py:
##########
@@ -227,18 +227,21 @@ async def run(self) -> typing.AsyncIterator[TriggerEvent]:
runs_ids_or_dates = len(self.execution_dates)
if AIRFLOW_V_3_0_PLUS:
- data = await
self.validate_count_dags_af_3(runs_ids_or_dates_len=runs_ids_or_dates)
- yield TriggerEvent(data)
+ cls_path, data = await
self.validate_count_dags_af_3(runs_ids_or_dates_len=runs_ids_or_dates)
+ yield TriggerEvent((cls_path, data))
return
else:
while True:
num_dags = await self.count_dags()
if num_dags == runs_ids_or_dates:
- yield TriggerEvent(self.serialize())
+ cls_path, data = self.serialize()
+ yield TriggerEvent((cls_path, data))
Review Comment:
Yes, it does not have to be changed, I think it's more clear this way -
`serialize` returns tuple with two elements and we pass them both to
TriggerEvent, just as in AF3 branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
