uranusjr commented on code in PR #58497:
URL: https://github.com/apache/airflow/pull/58497#discussion_r2545495330
##########
providers/standard/src/airflow/providers/standard/triggers/external_task.py:
##########
@@ -226,23 +226,27 @@ async def run(self) -> typing.AsyncIterator[TriggerEvent]:
elif self.execution_dates:
runs_ids_or_dates = len(self.execution_dates)
+ cls_path, data = self.serialize()
+
if AIRFLOW_V_3_0_PLUS:
- data = await
self.validate_count_dags_af_3(runs_ids_or_dates_len=runs_ids_or_dates)
- yield TriggerEvent(data)
+ data.update(
+ await self.validate_count_dags_af_3(data=data,
runs_ids_or_dates_len=runs_ids_or_dates)
+ )
Review Comment:
The way you implement the function `update` shouldn’t be called (`data` is
just modified in place)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
