pierrejeambrun commented on code in PR #58359:
URL: https://github.com/apache/airflow/pull/58359#discussion_r2560247429
##########
airflow-core/src/airflow/ui/src/layouts/Details/Grid/GridTI.tsx:
##########
@@ -106,35 +109,44 @@ const Instance = ({ dagId, instance, isGroup, isMapped,
onClick, runId, taskId }
py={0}
transition="background-color 0.2s"
>
- <Link
- id={`grid-${runId}-${taskId}`}
- onClick={onClick}
- replace
- to={{
- pathname: getTaskUrl(),
- search: redirectionSearch,
- }}
+ <BasicTooltip
+ content={
+ <>
+ {translate("taskId")}: {taskId}
+ <br />
+ {translate("state")}:{" "}
+ {instance.state
+ ? translate(`common:states.${instance.state}`)
+ : translate("common:states.no_status")}
+ {instance.min_start_date !== null && (
+ <>
+ <br />
+ {translate("startDate")}: <Time
datetime={instance.min_start_date} />
+ </>
+ )}
+ {instance.max_end_date !== null && (
+ <>
+ <br />
+ {translate("endDate")}: <Time datetime={instance.max_end_date}
/>
+ </>
+ )}
+ {Boolean(duration) && (
+ <>
+ <br />
+ {translate("duration")}: {duration}
+ </>
+ )}
+ </>
+ }
Review Comment:
We should move this to its own PR. Because this will only work for task
group, if we want this everywhere, we need to discuss if we want to update the
backend TiSummary, or not.
In any case I think it's unrelated to this PR, and to not make the scope
bigger I would split it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
