guan404ming commented on code in PR #58359:
URL: https://github.com/apache/airflow/pull/58359#discussion_r2575844882
##########
airflow-core/src/airflow/ui/src/layouts/Details/Grid/GridButton.tsx:
##########
@@ -41,39 +43,53 @@ export const GridButton = ({
state,
taskId,
...rest
-}: Props) =>
- isGroup ? (
- <Flex
- background={`${state}.solid`}
- borderRadius={2}
- height="10px"
- minW="14px"
- pb="2px"
- px="2px"
- title={`${label}\n${state}`}
- {...rest}
- >
- {children}
- </Flex>
- ) : (
- <Link
- replace
- to={{
- pathname: `/dags/${dagId}/runs/${runId}/${taskId === undefined ? "" :
`tasks/${taskId}`}`,
- search: searchParams.toString(),
- }}
- >
+}: Props) => {
+ const { t: translate } = useTranslation();
+
+ const tooltipContent = (
+ <>
+ {label}
+ <br />
+ {translate("state")}:{" "}
+ {state ? translate(`common:states.${state}`) :
translate("common:states.no_status")}
+ </>
+ );
+
+ return isGroup ? (
+ <BasicTooltip content={tooltipContent}>
<Flex
background={`${state}.solid`}
borderRadius={2}
height="10px"
+ minW="14px"
pb="2px"
px="2px"
- title={`${label}\n${state}`}
- width="14px"
{...rest}
>
{children}
</Flex>
- </Link>
+ </BasicTooltip>
+ ) : (
+ <BasicTooltip content={tooltipContent}>
+ <Link
+ replace
+ to={{
+ pathname: `/dags/${dagId}/runs/${runId}/${taskId === undefined ? ""
: `tasks/${taskId}`}`,
Review Comment:
Small nit, We could reuse the `buildTaskInstanceUrl`.
##########
airflow-core/src/airflow/ui/src/components/BasicTooltip.tsx:
##########
@@ -0,0 +1,122 @@
+/*!
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import { Box, Portal } from "@chakra-ui/react";
+import type { ReactElement, ReactNode } from "react";
+import { cloneElement, useCallback, useEffect, useRef, useState } from "react";
+
+type Props = {
+ readonly children: ReactElement;
+ readonly content: ReactNode;
+};
+
+const offset = 8;
+// Estimated tooltip height for viewport boundary detection
+const estimatedTooltipHeight = 100;
+
+export const BasicTooltip = ({ children, content }: Props): ReactElement => {
+ const triggerRef = useRef<HTMLElement>(null);
+ const [isOpen, setIsOpen] = useState(false);
+ const [showOnTop, setShowOnTop] = useState(false);
+ const timeoutRef = useRef<NodeJS.Timeout>();
+
+ const handleMouseEnter = useCallback(() => {
+ if (timeoutRef.current) {
+ clearTimeout(timeoutRef.current);
+ }
+ timeoutRef.current = setTimeout(() => {
+ // Check if tooltip would overflow viewport bottom
+ if (triggerRef.current) {
+ const triggerRect = triggerRef.current.getBoundingClientRect();
+ const wouldOverflow = triggerRect.bottom + offset +
estimatedTooltipHeight > globalThis.innerHeight;
+
+ setShowOnTop(wouldOverflow);
+ }
+ setIsOpen(true);
+ }, 500);
Review Comment:
I think 500ms is better based on my local test, but open to any opinion!
##########
airflow-core/src/airflow/ui/src/components/BasicTooltip.tsx:
##########
@@ -0,0 +1,127 @@
+/*!
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import { Box, Portal } from "@chakra-ui/react";
+import type { ReactElement, ReactNode } from "react";
+import { cloneElement, useCallback, useEffect, useLayoutEffect, useRef,
useState } from "react";
+
+type Props = {
+ readonly children: ReactElement;
+ readonly content: ReactNode;
+};
+
+const offset = 8;
+
+export const BasicTooltip = ({ children, content }: Props): ReactElement => {
+ const triggerRef = useRef<HTMLElement>(null);
+ const tooltipRef = useRef<HTMLDivElement>(null);
+ const [isOpen, setIsOpen] = useState(false);
+ const [showOnTop, setShowOnTop] = useState(false);
+ const timeoutRef = useRef<NodeJS.Timeout>();
+
+ const handleMouseEnter = useCallback(() => {
+ if (timeoutRef.current) {
+ clearTimeout(timeoutRef.current);
+ }
+ timeoutRef.current = setTimeout(() => {
+ setIsOpen(true);
+ }, 500);
+ }, []);
+
+ const handleMouseLeave = useCallback(() => {
+ if (timeoutRef.current) {
+ clearTimeout(timeoutRef.current);
+ timeoutRef.current = undefined;
+ }
+ setIsOpen(false);
+ }, []);
+
+ // Calculate position based on actual tooltip height before paint
+ useLayoutEffect(() => {
+ if (isOpen && triggerRef.current && tooltipRef.current) {
+ const triggerRect = triggerRef.current.getBoundingClientRect();
+ const tooltipHeight = tooltipRef.current.clientHeight;
+ const wouldOverflow = triggerRect.bottom + offset + tooltipHeight >
globalThis.innerHeight;
+
+ setShowOnTop(wouldOverflow);
+ }
+ }, [isOpen]);
+
+ // Cleanup on unmount
Review Comment:
I'm not sure whether we should need this, could you help confirm this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
