potiuk commented on issue #6596: [AIRFLOW-6004] Untangle Executors class to 
avoid cyclic imports
URL: https://github.com/apache/airflow/pull/6596#issuecomment-558990446
 
 
   Hey @kaxil @ashb @feluelle @mik-laj -> I have just pushed a rebased version 
with all the fixes from conversation above, rebased on top of latest master - 
it should (I hope) have all the tests fixed and it is also stable in terms of 
cyclic imports (pylint is serialized and a lot of the executor-related 
dependencies are untangled. 
   
   I withdrew from making more fixes with type annotations - this is a minimal 
set of changes that makes executor types more developer friendly. There are 
many more types in surrounding files that can be fixed, but I figured it can 
take much longer time and I will do it separately (at some point in time - not 
now...). Pls take a look and I think we can close it for now after this last 
round of reviews (I will come back to type fixing and dependencies later).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to