potiuk commented on issue #6596: [AIRFLOW-6004] Untangle Executors class to avoid cyclic imports URL: https://github.com/apache/airflow/pull/6596#issuecomment-559273232 > > I will add -> Nones to all the changed classes with no return value > > Doesn't mypy infer that automatically? Nope - see the answer to @feluelle: > There is a subtle difference explained here: https://realpython.com/python-type-checking/#functions-without-return-values > > If you specify -> None, then you will get warning if you try to assign return value to a variable. If you don't - you get no warning (None is still a valid return value that you can assign to something). So I started to add it (but not consistently, True). > I might review the changes and add -> None in all the affected non-return functions and try to do it in the future as well.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
