potiuk commented on code in PR #56187: URL: https://github.com/apache/airflow/pull/56187#discussion_r2569502843
########## airflow-core/src/airflow/observability/traces/otel_tracer.py: ########## @@ -0,0 +1,41 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +from __future__ import annotations + +from typing import TYPE_CHECKING + +from airflow._shared.observability.traces import otel_tracer +from airflow.configuration import conf Review Comment: There should be no `from airflow.` or even `from `airflow._shared` here. All imports in the shared library should be: * relative if the they refer to same shared package you are in * from airflow_shared.* if they refer to another shared library in tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
