xBis7 commented on code in PR #56187:
URL: https://github.com/apache/airflow/pull/56187#discussion_r2569516828
##########
shared/observability/src/airflow_shared/observability/metrics/statsd_logger.py:
##########
@@ -155,13 +158,25 @@ def timer(
return Timer()
-def get_statsd_logger(cls) -> SafeStatsdLogger:
+def get_statsd_logger(
+ cls,
+ stats_class: Callable[[str], str] | None = None,
+ host: str | None = None,
+ port: int | None = None,
+ prefix: str | None = None,
+ ipv6: bool = False,
+ influxdb_tags_enabled: bool = False,
+ statsd_disabled_tags: str | None = None,
+ metrics_allow_list: str | None = None,
+ metrics_block_list: str | None = None,
+ stat_name_handler: Callable[[str], str] | None = None,
+ statsd_influxdb_enabled: bool = False,
+) -> SafeStatsdLogger:
"""Return logger for StatsD."""
# no need to check for the scheduler/statsd_on -> this method is only
called when it is set
# and previously it would crash with None is callable if it was called
without it.
from statsd import StatsClient
- stats_class = conf.getimport("metrics", "statsd_custom_client_path",
fallback=None)
if stats_class:
if not issubclass(stats_class, StatsClient):
raise AirflowConfigException(
Review Comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
