choo121600 commented on code in PR #1293:
URL: https://github.com/apache/airflow-site/pull/1293#discussion_r2579535831
##########
landing-pages/site/layouts/_default/baseof.html:
##########
@@ -32,7 +32,14 @@
<main role="main" class="td-main container">
{{ block "main" . }}{{ end }}
</main>
- {{ partial "suggest-change" . }}
+ <div class="base-layout--button">
+ <div class="base-layout--scrollButton">
+ {{ partial "scroll-to-top" . }}
+ </div>
+ <div class="base-layout--suggestButton">
+ {{ partial "suggest-change" . }}
+ </div>
+ </div>
Review Comment:
It’s a small suggestion, but you could also consider doing it like this ;)
This can be applied to all other `baseof.html` files as well.
```html
</main>
<div class="base-layout--button">
<div class="base-layout--scrollButton">
{{ partial "scroll-to-top" . }}
</div>
<div class="base-layout--suggestButton">
{{ partial "suggest-change" . }}
</div>
</div>
</div>
</div>
{{ partialCached "footer.html" . }}
{{ partial "scripts.html" . }}
</body>
```
##########
landing-pages/site/assets/scss/_base-layout.scss:
##########
Review Comment:
I think you can make this blow. (remove &--bothButtons)
```scss
.base-layout {
// padding: 123px 0 40px;
padding: 163px 0 40px; // TEMP - accommodate Airflow Summit banner (123 +
40)
&--scrollButton {
position: sticky;
width: 100%;
margin-left: 40px;
margin-right: 40px;
bottom: 40px;
z-index: 1;
}
&--suggestButton {
display: flex;
justify-content: flex-end;
position: sticky;
width: 100%;
margin-left: auto;
margin-right: 40px;
bottom: 40px;
z-index: 1;
}
&--button {
display: flex;
position: sticky;
width: 100%;
margin-left: auto;
margin-right: 40px;
bottom: 40px;
justify-content: space-between;
z-index: 1;
}
}
@media (max-width: $tablet) {
.base-layout {
padding: 76px 0 60px;
&--suggestButton{
display: none;
}
&--scrollButton button span {
display: none;
}
&--scrollButton button {
width: 55px;
height: 55px;
display: flex;
align-items: center;
justify-content: center;
padding: 0;
}
&--scrollButton button svg {
flex-shrink: 0;
}
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
