pierrejeambrun commented on code in PR #58881:
URL: https://github.com/apache/airflow/pull/58881#discussion_r2580683674
##########
airflow-core/src/airflow/ui/src/utils/links.ts:
##########
@@ -17,7 +17,22 @@
* under the License.
*/
import type { TaskInstanceResponse } from "openapi/requests/types.gen";
-import { taskInstanceRoutes } from "src/router";
+
+const DAG_RUN_ROUTES = ["required_actions", "asset_events", "events", "code",
"details"] as const;
+const TASK_ROUTES = ["task_instances", "required_actions", "events"] as const;
+const TASK_INSTANCE_ROUTES = [
+ "required_actions",
+ "rendered_templates",
+ "xcom",
+ "asset_events",
+ "events",
+ "code",
+ "details",
+] as const;
Review Comment:
Similarly to what we had before, can this come from the router definition ?
Having an hardcoded list here and in the router will make things harder to
maintain. They can easily go out of sync.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
