aaron-wolmutt commented on PR #58981: URL: https://github.com/apache/airflow/pull/58981#issuecomment-3614126337
> @aaron-wolmutt My guess for test failure is that the Logs.test.tsx selects by "settings" being case insensitive to test settings button in the logs component. Since the translation changed from "user" to "navUserSettings.user" the nav bar button is also matched resulting in two buttons for /settings/iu regex and thus results in error. Using "user" translation passes. Please run `pnpm test` to fix this locally. > > ``` > <button > aria-haspopup="menu" > class="chakra-button chakra-menu__trigger css-1r6vxmd" > data-part="trigger" > data-scope="menu" > data-state="closed" > data-uid="«r17»" > dir="ltr" > id="menu:«r17»:trigger" > title="navUserSettings.user" > type="button" > > > <svg > aria-hidden="true" > class="chakra-icon css-jhpzjc" > fill="none" > focusable="false" > height="1em" > stroke="currentColor" > stroke-linecap="round" > stroke-linejoin="round" > stroke-width="2" > viewBox="0 0 24 24" > width="1em" > xmlns="http://www.w3.org/2000/svg"; > > > <path > d="M20 21v-2a4 4 0 0 0-4-4H8a4 4 0 0 0-4 4v2" > /> > <circle > cx="12" > cy="7" > r="4" > /> > </svg> > <div > class="css-1h3hbcr" > > > navUserSettings.user > </div> > </button> > > > <button > aria-haspopup="menu" > class="chakra-button chakra-menu__trigger css-y5du55" > data-part="trigger" > data-scope="menu" > data-state="closed" > data-uid="«r1t»" > dir="ltr" > id="menu:«r1t»:trigger" > type="button" > > > <svg > fill="currentColor" > height="1em" > stroke="currentColor" > stroke-width="0" > viewBox="0 0 24 24" > width="1em" > xmlns="http://www.w3.org/2000/svg"; > > > <path > d="M0 0h24v24H0V0z" > fill="none" > /> > <path > d="M19.14 12.94c.04-.3.06-.61.06-.94 0-.32-.02-.64-.07-.94l2.03-1.58a.49.49 0 0 0 .12-.61l-1.92-3.32a.488.488 0 0 0-.59-.22l-2.39.96c-.5-.38-1.03-.7-1.62-.94l-.36-2.54a.484.484 0 0 0-.48-.41h-3.84c-.24 0-.43.17-.47.41l-.36 2.54c-.59.24-1.13.57-1.62.94l-2.39-.96c-.22-.08-.47 0-.59.22L2.74 8.87c-.12.21-.08.47.12.61l2.03 1.58c-.05.3-.09.63-.09.94s.02.64.07.94l-2.03 1.58a.49.49 0 0 0-.12.61l1.92 3.32c.12.22.37.29.59.22l2.39-.96c.5.38 1.03.7 1.62.94l.36 2.54c.05.24.24.41.48.41h3.84c.24 0 .44-.17.47-.41l.36-2.54c.59-.24 1.13-.56 1.62-.94l2.39.96c.22.08.47 0 .59-.22l1.92-3.32c.12-.22.07-.47-.12-.61l-2.01-1.58zM12 15.6c-1.98 0-3.6-1.62-3.6-3.6s1.62-3.6 3.6-3.6 3.6 1.62 3.6 3.6-1.62 3.6-3.6 3.6z" > /> > </svg> > > logs.settings > </button> > ``` Yeah it looks like this test will fail if a new translation key is added that contains "settings". It's passing now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
