Re: [PR] feat: display logged in within UserSettingsButton [airflow]

Fri, 05 Dec 2025 08:54:13 -0800 


pierrejeambrun commented on code in PR #58981:
URL: https://github.com/apache/airflow/pull/58981#discussion_r2593332873


##########
airflow-core/src/airflow/ui/src/layouts/Nav/UserSettingsButton.tsx:
##########
@@ -91,6 +93,16 @@ export const UserSettingsButton = ({ externalViews }: { 
readonly externalViews:
           <NavButton icon={FiUser} title={translate("user")} />
         </Menu.Trigger>
         <Menu.Content>
+          {currentUser ? (
+            <Box borderBottom="1px solid" borderColor="border.muted" p={3}>

Review Comment:
   You need a separator similarly to what's bellow to actually do the 
horizontal line. (<Menu.Separator />)
   
   <img width="673" height="430" alt="Image" 
src="https://github.com/user-attachments/assets/9f717496-cda4-40f7-9819-03b3898b53ad";
 />
   
   
   Currently with your border bottom implementation it's now showing properly 
for me in darkmode:
   <img width="459" height="318" alt="Image" 
src="https://github.com/user-attachments/assets/5ec3cae7-da58-42a8-84a3-650068c7bb24";
 />



##########
generated/PYPI_README.md:
##########
@@ -28,7 +28,7 @@ PROJECT BY THE `generate-pypi-readme` PREK HOOK. YOUR CHANGES 
HERE WILL BE AUTOM
 | PyPI       | [![PyPI 
version](https://badge.fury.io/py/apache-airflow.svg)](https://badge.fury.io/py/apache-airflow)
 [![PyPI - Python 
Version](https://img.shields.io/pypi/pyversions/apache-airflow.svg)](https://pypi.org/project/apache-airflow/)
 [![PyPI - 
Downloads](https://img.shields.io/pypi/dm/apache-airflow)](https://pypi.org/project/apache-airflow/)
                                                                                
                                                                                
               |
 | Containers | [![Docker 
Pulls](https://img.shields.io/docker/pulls/apache/airflow.svg)](https://hub.docker.com/r/apache/airflow)
 [![Docker 
Stars](https://img.shields.io/docker/stars/apache/airflow.svg)](https://hub.docker.com/r/apache/airflow)
 [![Artifact 
HUB](https://img.shields.io/endpoint?url=https://artifacthub.io/badge/repository/apache-airflow)](https://artifacthub.io/packages/search?repo=apache-airflow)
                                                                                
                                      |
 | Community  | 
[![Contributors](https://img.shields.io/github/contributors/apache/airflow)](https://github.com/apache/airflow/graphs/contributors)
 [![Slack 
Status](https://img.shields.io/badge/slack-join_chat-white.svg?logo=slack&style=social)](https://s.apache.org/airflow-slack)
 ![Commit 
Activity](https://img.shields.io/github/commit-activity/m/apache/airflow) 
[![LFX Health 
Score](https://insights.linuxfoundation.org/api/badge/health-score?project=apache-airflow)](https://insights.linuxfoundation.org/project/apache-airflow)
  |
-| Dev tools  | 
[![prek](https://img.shields.io/endpoint?url=https://raw.githubusercontent.com/j178/prek/master/assets/badge/v0.json)](https://github.com/j178/prek)
                                                                                
                                                                                
                                                                                
                                                                                
                                                 |
+| Dev tools  | 
[![prek](https://img.shields.io/endpoint?url=https://raw.githubusercontent.com/j178/prek/master/docs/assets/badge-v0.json)](https://github.com/j178/prek)
                                                                                
                                                                                
                                                                                
                                                                                
                                                 |

Review Comment:
   This change is unrelated, can you remove it please.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to