shahar1 commented on code in PR #59136: URL: https://github.com/apache/airflow/pull/59136#discussion_r2595994845
########## dev/breeze/src/airflow_breeze/commands/ui_commands.py: ########## Review Comment: > I noticed something while looking at this logic. Right now, above 95% is marked as green, but we typically consider complete only when it’s at 100%. Would it make more sense to show green only when the coverage is exactly 100%? What do you think? The definition for completeness from the policy is actually above 90% :) I came up with this number so it would be high enough on one hand, but not too high to give some flexibility to all parties (for example, if translators of a specific language didn't catch recent changes on time). So you could thing of the range of 90%-100% as a traffic light, where 95%-100% is "safe" (green) , 90%-95% should ring a bell (yellow), and below 90% needs a wake up call (red). I hope that it makes sense. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
