amoghrajesh commented on code in PR #59136: URL: https://github.com/apache/airflow/pull/59136#discussion_r2597097806
########## airflow-core/src/airflow/ui/public/i18n/README.md: ########## @@ -366,11 +366,11 @@ breeze ui check-translation-completeness --verbose --all-files ## 11. Freeze time -Few weeks before a minor or major release, a freeze time for accepting new translations -MUST be announced in the dev list, to allow time for testing and verification of translations. +A few weeks before a minor or major release, a freeze time for accepting new translations, might be announced in the dev list by the Release Manager. +It should be announced when the median coverage across all translations is below the completeness threshold, or when needed (e.g., due to a critical UI feature that requires many new terms to be added). Review Comment: What's the "threshold" and how is it measured? ########## airflow-core/src/airflow/ui/public/i18n/README.md: ########## @@ -366,11 +366,11 @@ breeze ui check-translation-completeness --verbose --all-files ## 11. Freeze time -Few weeks before a minor or major release, a freeze time for accepting new translations -MUST be announced in the dev list, to allow time for testing and verification of translations. +A few weeks before a minor or major release, a freeze time for accepting new translations, might be announced in the dev list by the Release Manager. +It should be announced when the median coverage across all translations is below the completeness threshold, or when needed (e.g., due to a critical UI feature that requires many new terms to be added). Review Comment: I see below its through a script, better to mention that here ########## airflow-core/src/airflow/ui/public/i18n/README.md: ########## @@ -366,11 +366,11 @@ breeze ui check-translation-completeness --verbose --all-files ## 11. Freeze time -Few weeks before a minor or major release, a freeze time for accepting new translations -MUST be announced in the dev list, to allow time for testing and verification of translations. +A few weeks before a minor or major release, a freeze time for accepting new translations, might be announced in the dev list by the Release Manager. Review Comment: ```suggestion A few weeks before a minor or major release, a freeze time for accepting new translations MAY be announced in the dev list by the Release Manager. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
