dabla commented on PR #59087:
URL: https://github.com/apache/airflow/pull/59087#issuecomment-3625787421

   > It’s indeed cleaner from the implementation-wise, but I’d prefer 
PythonOperator to just work with async functions, instead of needing a separate 
class. It’d be easier if there’s one class instead of two since 
PythonVirtualenvOperator etc. would also work.
   
   Thanks TP for you remark, you're indeed right, didn't really think about it 
as you don't see it when using the @task decorator, but that would be indeed 
annoying if you had to use another PythonOperator for async functions, good 
catch!
   
   I will fix this, but that would of course mean the PythonOperator would by 
default extend the BaseAsyncOperator instead of the BaseOperator, but that's 
not an issue I suppose.  The the is_async property will need to be overriden in 
the PythonOperator to be able to check the python_callable if it's async or not.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to