pierrejeambrun commented on code in PR #58092:
URL: https://github.com/apache/airflow/pull/58092#discussion_r2614138740
##########
airflow-core/src/airflow/api_fastapi/core_api/routes/public/task_instances.py:
##########
@@ -424,6 +425,7 @@ def get_task_instances(
update_at_range: Annotated[RangeFilter,
Depends(datetime_range_filter_factory("updated_at", TI))],
duration_range: Annotated[RangeFilter,
Depends(float_range_filter_factory("duration", TI))],
task_display_name_pattern: QueryTITaskDisplayNamePatternSearch,
+ task_group: QueryTITaskGroupFilter,
Review Comment:
Sorry for the nitpicking, since this is public API we need to make sure we
are consistent and things respect the naming convention because we will not be
able to update them afterward.
##########
airflow-core/src/airflow/api_fastapi/core_api/routes/public/task_instances.py:
##########
@@ -424,6 +425,7 @@ def get_task_instances(
update_at_range: Annotated[RangeFilter,
Depends(datetime_range_filter_factory("updated_at", TI))],
duration_range: Annotated[RangeFilter,
Depends(float_range_filter_factory("duration", TI))],
task_display_name_pattern: QueryTITaskDisplayNamePatternSearch,
+ task_group: QueryTITaskGroupFilter,
Review Comment:
```suggestion
task_group_id: QueryTITaskGroupFilter,
```
##########
airflow-core/src/airflow/api_fastapi/core_api/routes/public/task_instances.py:
##########
@@ -424,6 +425,7 @@ def get_task_instances(
update_at_range: Annotated[RangeFilter,
Depends(datetime_range_filter_factory("updated_at", TI))],
duration_range: Annotated[RangeFilter,
Depends(float_range_filter_factory("duration", TI))],
task_display_name_pattern: QueryTITaskDisplayNamePatternSearch,
+ task_group: QueryTITaskGroupFilter,
Review Comment:
```suggestion
task_group_id: QueryTITaskGroupFilter,
```
##########
airflow-core/src/airflow/api_fastapi/core_api/routes/public/task_instances.py:
##########
@@ -424,6 +425,7 @@ def get_task_instances(
update_at_range: Annotated[RangeFilter,
Depends(datetime_range_filter_factory("updated_at", TI))],
duration_range: Annotated[RangeFilter,
Depends(float_range_filter_factory("duration", TI))],
task_display_name_pattern: QueryTITaskDisplayNamePatternSearch,
+ task_group: QueryTITaskGroupFilter,
Review Comment:
Sorry for the nitpicking, since this is public API we need to make sure we
are consistent and things respect the naming convention because we will not be
able to update them afterward.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
