zach-overflow commented on PR #59239: URL: https://github.com/apache/airflow/pull/59239#issuecomment-3649349375
> Thanks for adding the nice feature! > > Would it be better that Triggerer only add the SQL filter if user specify `--consume-trigger-queues` from CLI without adding the new configs? > > Not sure if this would be not only less ambiguous for users but also make the SQL unchanged by only applying the `trigger_queue.in_` filter when users explicitly pass the `--consume-trigger-queues` flag. In my opinion, this preserves the feature while minimizing changes. Thanks for the suggestion, I like that idea and am all in favor of reduced ambiguity. On that topic there's one other area I want to get some thoughts on: Should the `consume-trigger-queues` option be available both in the CLI **and** the Airflow config? Or just one or the other? I can see some usefulness in surfacing that setting in both the CLI and the config, but at the same time maybe that also adds unnecessary ambiguity? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
