kacpermuda commented on issue #59370:
URL: https://github.com/apache/airflow/issues/59370#issuecomment-3655382496
Hey @tstrilka , thanks for the PR. I think if we could improve documentation
on this method in listener spec even more, saying something like this will only
be fired if the task actually started execution and was skipped by itself. We
should underline, that this will not be fired for most common scenarios, when
skipping happens on the scheduler due to trigger rules, branching operators etc.
I think we should definitely decouple the Airflow core & SDK part of the PR
from OpenLineage provider part. It will be easier to review, as those parts
have different code owners. I'll be happy to review the OpenLineage PR once the
core/sdk changes are merged.
In general, I agree with @mobuchowski , it can give the users a sense of
"false security" ("it will always fire when my task is skipped"), but I think
if we document it well enough, it will fill in some gaps we have now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
