tstrilka commented on issue #59370:
URL: https://github.com/apache/airflow/issues/59370#issuecomment-3656075162
Thanks for the feedback @mobuchowski and @kacpermuda!
I've addressed all the comments:
1. **Split the PR** - Closed #59371 and created #59467 with core Airflow/SDK
changes only (hookspec + task_runner + test). OpenLineage provider
implementation will come in a separate PR after this merges.
2. **Improved documentation** - Updated the hookspec docstring to clearly
state:
- Hook fires only when a task raises `AirflowSkipException` (self-skip)
- Does NOT cover scheduler-level skips (trigger rules,
BranchPythonOperator, ShortCircuitOperator, etc.)
- Recommends DAG-level listeners for comprehensive skip tracking
**Next steps:**
1. Review and merge #59467 (core changes)
2. I'll submit a follow-up PR for OpenLineage provider implementation
PR ready for review: https://github.com/apache/airflow/pull/59467
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]