ephraimbuddy commented on code in PR #59372:
URL: https://github.com/apache/airflow/pull/59372#discussion_r2627389156
##########
providers/cncf/kubernetes/src/airflow/providers/cncf/kubernetes/utils/pod_manager.py:
##########
@@ -487,12 +487,15 @@ def consume_logs(*, since_time: DateTime | None = None)
-> tuple[DateTime | None
message_timestamp = line_timestamp
progress_callback_lines.append(line)
else: # previous log line is complete
- for line in progress_callback_lines:
+ if message_to_log is not None:
Review Comment:
This line is not needed because line 485 above and 489 already ensured
there's message to log or am I missing something?
##########
providers/cncf/kubernetes/src/airflow/providers/cncf/kubernetes/utils/pod_manager.py:
##########
@@ -487,12 +487,15 @@ def consume_logs(*, since_time: DateTime | None = None)
-> tuple[DateTime | None
message_timestamp = line_timestamp
progress_callback_lines.append(line)
else: # previous log line is complete
- for line in progress_callback_lines:
Review Comment:
Here progress_callback_lines contains lines of logs.
Can you share the full logs you were getting.
##########
providers/cncf/kubernetes/src/airflow/providers/cncf/kubernetes/callbacks.py:
##########
@@ -189,12 +191,22 @@ def on_operator_resuming(
pass
@staticmethod
- def progress_callback(*, line: str, client: client_type, mode: str,
**kwargs) -> None:
+ def progress_callback(
+ *,
+ line: str,
+ client: client_type,
+ mode: str,
+ container_name: str,
Review Comment:
```suggestion
container_name: str|None = None,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
