potiuk commented on PR #59430:
URL: https://github.com/apache/airflow/pull/59430#issuecomment-3666528308
> > I think we should have an opt-out solution for those that doesn't mind
the dag being non deterministic.
100%
> I agree that too. I think there are two options
>
> * making config section for disabling it (e.g.
AIRFLOW__DAG_PROCESSOR_ENABLE_PARSING_WARNING)
> * as Jarek said, suppress it by comment in the Dag
I think (despite Airflow having too many configuration parameters already)
there should be few ways:
* Comments have this drawbacks that they are missing from AST. So possibly
we should have something similar to when we check for `Dag` in the source code
- and possibly even in the same time to avoid double reading the Dag to memory
and with the same control to disable it
* Maybe we should have some .airflowignore style exclude as well - I can
easily imagine filename patter-matching in play here.
* Maybe we should - by default exclude non-versioned Dags from this warning.
This would be pretty much backwards-compatible for those who don't care about
versioning (though I believe there is the effect of continuously overriding
SerialzedDag in case of non-versioned Dags, but that is less problematic and
Airflow had no problems handling it in the past.
* Also global flag disabling or enabling it globally. Here maybe also we
could have a three-value check:
* None
* Alll
* OnlyVersioned (default)
* Finally I think we might have another global flag "Treat unstable Dag
warnings as errors". I imagine situatoin where some users would like to
absolutely not want unstable Dags.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
