potiuk commented on code in PR #59430:
URL: https://github.com/apache/airflow/pull/59430#discussion_r2644086300
##########
airflow-core/src/airflow/dag_processing/processor.py:
##########
@@ -200,22 +201,34 @@ def _parse_file_entrypoint():
sys.path.append(bundle_root)
result = _parse_file(msg, log)
+
if result is not None:
comms_decoder.send(result)
def _parse_file(msg: DagFileParseRequest, log: FilteringBoundLogger) ->
DagFileParsingResult | None:
# TODO: Set known_pool names on DagBag!
+ static_check_result = check_dag_file_static(os.fspath(msg.file))
Review Comment:
same here - > I think we should make it clear that this is a "dag stability"
check - not "static check" in general.
##########
airflow-core/src/airflow/dag_processing/processor.py:
##########
@@ -200,22 +201,34 @@ def _parse_file_entrypoint():
sys.path.append(bundle_root)
result = _parse_file(msg, log)
+
if result is not None:
comms_decoder.send(result)
def _parse_file(msg: DagFileParseRequest, log: FilteringBoundLogger) ->
DagFileParsingResult | None:
# TODO: Set known_pool names on DagBag!
+ static_check_result = check_dag_file_static(os.fspath(msg.file))
Review Comment:
same here -> names should be updated - > I think we should make it clear
that this is a "dag stability" check - not "static check" in general.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
