romsharon98 commented on PR #59290: URL: https://github.com/apache/airflow/pull/59290#issuecomment-3670315788
> I would say - yes, we want, but the question is how. Looking at the Helm Chart and different settings like `annotations`, there is a clear distinction based on where the values are applied (`annotations`, e.g. Deployment level and `podAnnotations` for pod level), but there is no such logic in terms of `labels`, and maybe it should be? > > So, basically, add `podLabels` section to each component, and these labels would be applied on the pod level, and the `labels` will be added on, e.g. `Deployment` level. When `podLabels` would be undefined, the values could go to the pod level from `labels` and not to the `Deployment` level to ensure backward compatibility. > > WDYT? Sounds good to me but lets wait for another opinion. @potiuk @eladkal @jedcunningham 🙌 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
