Lee-W commented on code in PR #58659:
URL: https://github.com/apache/airflow/pull/58659#discussion_r2633982164
##########
airflow-core/src/airflow/cli/commands/config_command.py:
##########
@@ -48,6 +55,8 @@ def show_config(args):
include_providers=not args.exclude_providers,
comment_out_everything=args.comment_out_everything or
args.defaults,
only_defaults=args.defaults,
+ non_sensitive=args.non_sensitive,
+ show_values=args.show_values,
Review Comment:
if not, then we probably don't need the `getattr` check?
##########
airflow-core/src/airflow/cli/commands/config_command.py:
##########
@@ -37,6 +38,12 @@
@providers_configuration_loaded
def show_config(args):
"""Show current application configuration."""
+ show_values = getattr(args, "show_values", False)
+ if not show_values:
Review Comment:
```suggestion
if not (show_values := getattr(args, "show_values", False)):
```
##########
airflow-core/src/airflow/cli/commands/config_command.py:
##########
@@ -48,6 +55,8 @@ def show_config(args):
include_providers=not args.exclude_providers,
comment_out_everything=args.comment_out_everything or
args.defaults,
only_defaults=args.defaults,
+ non_sensitive=args.non_sensitive,
+ show_values=args.show_values,
Review Comment:
```suggestion
show_values=show_values,
```
##########
airflow-core/src/airflow/cli/commands/config_command.py:
##########
@@ -48,6 +55,8 @@ def show_config(args):
include_providers=not args.exclude_providers,
comment_out_everything=args.comment_out_everything or
args.defaults,
only_defaults=args.defaults,
+ non_sensitive=args.non_sensitive,
+ show_values=args.show_values,
Review Comment:
Will it be an issue if `args.show_values` does not exist? (since you use
getattr to check above)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
