arnoldmr01 commented on code in PR #58659:
URL: https://github.com/apache/airflow/pull/58659#discussion_r2634572635
##########
airflow-core/src/airflow/cli/commands/config_command.py:
##########
@@ -48,6 +55,8 @@ def show_config(args):
include_providers=not args.exclude_providers,
comment_out_everything=args.comment_out_everything or
args.defaults,
only_defaults=args.defaults,
+ non_sensitive=args.non_sensitive,
+ show_values=args.show_values,
Review Comment:
If `args.show_values` does not exit, I think it will cause `AttributeError`.
However
`
ARG_CONFIG_SHOW_VALUES = Arg(
("--show-values",),
action="store_true",
help=(
"Show configuration values. "
"By default only option names are shown and values (including
potentially "
"sensitive ones) are hidden."
),
)
`
may ensure that `args.show_values` exit.
In this situation, do you think we can just directly use args.show_values?
Or is there any suggesting?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
