amoghrajesh commented on code in PR #59688:
URL: https://github.com/apache/airflow/pull/59688#discussion_r2642392323
##########
providers/common/compat/src/airflow/providers/common/compat/sdk.py:
##########
@@ -90,6 +90,7 @@
TaskDeferred as TaskDeferred,
XComNotFound as XComNotFound,
)
+ from airflow.sdk.log import redact as redact
Review Comment:
```suggestion
from airflow.sdk.log import redact
```
##########
task-sdk/src/airflow/sdk/log.py:
##########
@@ -37,7 +37,7 @@
from airflow.sdk.types import Logger, RuntimeTaskInstanceProtocol as
RuntimeTI
-__all__ = ["configure_logging", "reset_logging", "mask_secret"]
+from airflow.sdk._shared.secrets_masker import redact
Review Comment:
We will likely need a `as redact` or it may complain with `noqa`
##########
providers/microsoft/azure/src/airflow/providers/microsoft/azure/hooks/msgraph.py:
##########
@@ -57,8 +57,7 @@
from kiota_abstractions.response_handler import NativeResponseType
from kiota_abstractions.serialization import ParsableFactory
- from airflow.providers.common.compat.sdk import Connection
-
+from airflow.providers.common.compat.sdk import Connection, redact
Review Comment:
Connection is only for typing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
