amoghrajesh commented on code in PR #59688:
URL: https://github.com/apache/airflow/pull/59688#discussion_r2642652004
##########
task-sdk/src/airflow/sdk/log.py:
##########
@@ -37,7 +37,7 @@
from airflow.sdk.types import Logger, RuntimeTaskInstanceProtocol as
RuntimeTI
-__all__ = ["configure_logging", "reset_logging", "mask_secret"]
+from airflow.sdk._shared.secrets_masker import redact
Review Comment:
Would this not need `as redact`? We are re-exporting here
##########
providers/common/compat/src/airflow/providers/common/compat/sdk.py:
##########
@@ -90,6 +90,7 @@
TaskDeferred as TaskDeferred,
XComNotFound as XComNotFound,
)
+ from airflow.sdk.log import redact as redact
from airflow.sdk.observability.stats import Stats # noqa: F401
Review Comment:
Unrelate to this PR, could you fix the pattern on this line too to get rid
of noqa?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
