potiuk commented on code in PR #59778:
URL: https://github.com/apache/airflow/pull/59778#discussion_r2645140145
##########
scripts/in_container/install_airflow_and_providers.py:
##########
@@ -754,14 +763,59 @@ def compile_ui_assets(
cwd=os.fspath(source_ui_directory),
)
# copy compiled assets to installation directory
- dist_source_directory = source_ui_directory / "dist"
+ dist_source_directory = source_ui_directory / UI_DIST_DIR_NAME
console.print(
f"[bright_blue]Copying compiled UI assets from
'{dist_source_directory}' to '{dist_directory}'"
)
shutil.copytree(dist_source_directory, dist_directory)
console.print("[bright_blue]UI assets compiled successfully")
+def copy_mounted_ui_dist(mounted_ui_dist_source: Path, dist_prefix: str,
host_source_prefix: str):
Review Comment:
Hmm. I thinl rather than doing this copy, we could simply mount the folder
directly where it is expected to be? I don't think we need to use the temporary
folder to copy it from there inside?
Or am I wrong :) ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
