shahar1 commented on code in PR #59778: URL: https://github.com/apache/airflow/pull/59778#discussion_r2646227725
########## scripts/ci/docker-compose/mount-ui-dist.yml: ########## @@ -0,0 +1,26 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +--- +services: + airflow: + # Mount pre-built UI dist directories from host to container + # This allows using pre-compiled UI assets without rebuilding in container + volumes: + # Mount main UI dist directory + - ../../../airflow-core/src/airflow/ui/dist:/usr/python/lib/python3.10/site-packages/airflow/ui/dist:cached Review Comment: Python 3.10 is hardcoded here - but there's an option in breeze to set the Python to a different version. How do we handle this case? (ideas: dynamically resolve the version to allow flexibility, or if it's too complicated at this point\* - limit this feature to Python 3.10 only an raise an error if it's utilized). \* Or it may not be worth it, as we mostly use the earliest Python version that is not EOL for backward compatibility. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
